Minor simplification of finderMethodName predicate

2026-04-28 10:15:14 +02:00 · 2021-10-07 10:42:59 +01:00
parent eb8c48d10f
commit 8262247ed7
1 changed files with 1 additions and 1 deletions
--- a/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll
+++ b/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll
@@ -262,7 +262,7 @@ private string finderMethodName() {
        "fifth", "find", "find_by", "find_or_initialize_by", "find_or_create_by", "first",
        "forty_two", "fourth", "last", "second", "second_to_last", "take", "third", "third_to_last"
      ] and
-    (result = baseName or result = baseName + "!")
+    result = baseName + ["", "!"]
  )
  or
  result = "new"