hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-09 19:51:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

QL: Actually use the SuffixPredicateCall class as well. Now the query finds 20 results.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2021-10-13 09:31:45 +00:00
committed by GitHub
parent 812597505d
commit 81e88f8d34
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ql/src/queries/performance/PrefixSuffixEquality.ql
View File

@@ -36,7 +36,7 @@ bindingset[s]
string escape(string s) { result = s.replaceAll("_", "\\\\_").replaceAll("%", "\\\\%") }
pragma[inline]
string getMessage(Call call, String literal) {
string getMessage(FixPredicateCall call, String literal) {
call instanceof PrefixPredicateCall and
result = ".matches(\"" + escape(literal.getValue()) + "%\")"
or
@@ -44,6 +44,10 @@ string getMessage(Call call, String literal) {
result = ".matches(\"%" + escape(literal.getValue()) + "\")"
}
from EqFormula eq, PrefixPredicateCall call, String literal
class FixPredicateCall extends Call {
FixPredicateCall() { this instanceof PrefixPredicateCall or this instanceof SuffixPredicateCall }
}
from EqFormula eq, FixPredicateCall call, String literal
where eq.getAnOperand() = call and eq.getAnOperand() = literal
select eq, "Use " + getMessage(call, literal) + " instead."