hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ruby: lower severity of parse error to warning

Browse Source
This commit is contained in:
Arthur Baars
2023-03-08 16:37:01 +01:00
parent ebf0bb889b
commit 8096f86224
4 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ruby/extractor/src/extractor.rs
View File

@@ -294,7 +294,7 @@ impl<'a> Visitor<'a> {
.diagnostics_writer
.new_entry("parse-error", "Parse error");
&mesg
.severity(diagnostics::Severity::Error)
.severity(diagnostics::Severity::Warning)
.location(self.path, start_line, start_column, end_line, end_column)
.message(message, args);
if status_page {
@@ -405,7 +405,7 @@ impl<'a> Visitor<'a> {
loc,
self.diagnostics_writer
.new_entry("parse-error", "Parse error")
.severity(diagnostics::Severity::Error)
.severity(diagnostics::Severity::Warning)
.location(self.path, start_line, start_column, end_line, end_column)
.message(
"Unknown table type: {}",

4
ruby/ql/integration-tests/all-platforms/diagnostics/syntax-error/diagnostics.expected
View File

@@ -11,7 +11,7 @@
},
"markdownMessage": "A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or [exclude](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/customizing-code-scanning) the file from analysis.",
"plaintextMessage": "A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.",
"severity": "Error",
"severity": "Warning",
"source": {
"extractorName": "ruby",
"id": "ruby/parse-error",
@@ -34,7 +34,7 @@
},
"markdownMessage": "A parse error occurred (expected `end` symbol). Check the syntax of the file. If the file is invalid, correct the error or [exclude](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/customizing-code-scanning) the file from analysis.",
"plaintextMessage": "A parse error occurred (expected end symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.",
"severity": "Error",
"severity": "Warning",
"source": {
"extractorName": "ruby",
"id": "ruby/parse-error",

4
ruby/ql/lib/change-notes/2023-03-09-parse-error.md Normal file
View File

@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The severity of parse errors was reduced to warning (previously error).

2
ruby/ql/lib/codeql/ruby/Diagnostics.qll
View File

@@ -47,6 +47,6 @@ class Diagnostic extends @diagnostic {
}
/** A diagnostic relating to a particular error in extracting a file. */
class ExtractionError extends Diagnostic, @diagnostic_error {
class ExtractionError extends Diagnostic {
ExtractionError() { this.getTag() = "parse_error" }
}