hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review comment

Browse Source
This commit is contained in:
Tom Hvitved
2022-03-30 17:22:14 +02:00
parent 0fb28f4bc9
commit 7efe698e56
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
ruby/ql/lib/codeql/ruby/security/performance/ExponentialBackTracking.qll
View File

@@ -277,17 +277,6 @@ private class Trace extends TTrace {
result = "Step(" + s1 + ", " + s2 + ", " + t + ")"
)
}
/** Holds if the `i`th pair of this trace is `(s1, s2)`. */
predicate hasPair(int i, InputSymbol s1, InputSymbol s2) {
this = Step(s1, s2, _) and
i = 0
or
exists(Trace t |
this = Step(_, _, t) and
t.hasPair(i - 1, s1, s2)
)
}
}
/**
@@ -329,6 +318,17 @@ private class RelevantTrace extends Trace {
)
}
private Trace getSuffix(int i) {
i = 0 and
result = this
or
this.getSuffix(i - 1) = Step(_, _, result)
}
private predicate hasTuple(int i, InputSymbol s1, InputSymbol s2) {
this.getSuffix(i) = Step(s1, s2, _)
}
/** Gets a string corresponding to this trace. */
// the pragma is needed for the case where `intersect(s1, s2)` has multiple values,
// not for recursion
@@ -336,7 +336,7 @@ private class RelevantTrace extends Trace {
string concretise() {
result =
concat(int i, InputSymbol s1, InputSymbol s2 |
this.hasPair(i, s1, s2)
this.hasTuple(i, s1, s2)
|
intersect(s1, s2) order by i desc
)