hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Propagate React components through recompose HOCs

Browse Source
This commit is contained in:
Asger Feldthaus
2021-06-30 15:05:28 +02:00
parent 173be0cce0
commit 7e2871bfdf
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/src/semmle/javascript/frameworks/ComposedFunctions.qll
View File

@@ -88,7 +88,7 @@ module FunctionCompositionCall {
RightToLeft() {
this = DataFlow::moduleImport(["compose-function"]).getACall()
or
this = DataFlow::moduleMember(["redux", "ramda", "@reduxjs/toolkit"], "compose").getACall()
this = DataFlow::moduleMember(["redux", "ramda", "@reduxjs/toolkit", "recompose"], "compose").getACall()
or
this = LodashUnderscore::member("flowRight").getACall()
}

2
javascript/ql/src/semmle/javascript/frameworks/React.qll
View File

@@ -777,6 +777,8 @@ private DataFlow::SourceNode higherOrderComponentBuilder() {
or
result = DataFlow::moduleMember("redux-form", "reduxForm").getACall()
or
result = DataFlow::moduleMember("recompose", _).getACall()
or
result = reactRouterDom().getAPropertyRead("withRouter")
or
exists(FunctionCompositionCall compose |

5
javascript/ql/test/library-tests/frameworks/ReactJS/higherOrderComponent.jsx
View File

@@ -4,6 +4,7 @@ import { compose } from 'redux';
import styled from 'styled-components';
import unknownFunction from 'somewhere';
import { hot } from 'react-hot-loader';
import { withState } from 'recompose';
import { MyComponent } from './exportedComponent';
@@ -22,4 +23,6 @@ const withConnect = connect(mapStateToProps, mapDispatchToProps);
const ConnectedComponent = compose(withConnect, unknownFunction)(StyledComponent);
export default hot(module)(memo(ConnectedComponent));
const ConnectedComponent2 = withState('counter', 'setCounter', 0)(ConnectedComponent);
export default hot(module)(memo(ConnectedComponent2));