hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-02 00:02:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13257 from smowton/smowton/hotfix/useless-assignment-to-field-exclude-method-receivers

Browse Source 
Hotfix: Go: exclude method receivers from dead-store-of-field query
This commit is contained in:
Arthur Baars
2023-05-23 16:20:34 +02:00
committed by GitHub
parent a14f7dd153 99c211955b
commit 7c5fef37eb
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
go/ql/src/RedundantCode/DeadStoreOfField.ql
View File

@@ -38,6 +38,9 @@ predicate escapes(DataFlow::Node nd) {
// if `nd` is passed to a function, then it escapes
nd = any(DataFlow::CallNode c).getASyntacticArgument()
or
// if `nd` is the receiver of a function, then it escapes
nd = any(DataFlow::MethodCallNode c).getReceiver()
or
// if `nd` has its address taken, then it escapes
exists(AddressExpr ae | nd.asExpr() = ae.getOperand())
or