hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Do not generate def-nodes for decorated parameters

Browse Source
This commit is contained in:
Asger Feldthaus
2022-03-29 16:13:45 +02:00
parent ca145f21b0
commit 75a84378ac
3 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
View File

@@ -813,12 +813,6 @@ module API {
lbl = Label::decoratedMember() and
ref = DataFlow::valueNode(method.getBody())
)
or
exists(Parameter param |
useNodeFlowsToDecorator(base, param.getADecorator()) and
lbl = Label::decoratedParameter() and
ref = DataFlow::parameterNode(param)
)
}
/** Holds if `ref` is a use that should have an incoming edge from `base` labelled `lbl`, induced by a decorator. */
@@ -829,6 +823,12 @@ module API {
lbl = Label::decoratedMember() and
ref = DataFlow::parameterNode(accessor.getBody().getParameter(0))
)
or
exists(Parameter param |
useNodeFlowsToDecorator(base, param.getADecorator()) and
lbl = Label::decoratedParameter() and
ref = DataFlow::parameterNode(param)
)
}
/** Holds if `rhs` is a def node that should have an incoming edge from `base` labelled `lbl`, induced by a decorator. */

8
javascript/ql/test/library-tests/frameworks/data/paramDecorator.ts
View File

@@ -6,12 +6,12 @@ class C {
decoratedParamSource(@testlib.ParamDecoratorSource x) {
sink(x) // NOT OK
}
decoratedParamSink(@testlib.ParamDecoratorSink x) { // NOT OK - though slightly weird alert location
decoratedParamSink(@testlib.ParamDecoratorSink x) { // OK
}
decoratedParamSink2(@testlib.ParamDecoratorSink x) { // OK
x.push(source());
x.push(source()); // OK
}
}
new C().decoratedParamSink(source());
new C().decoratedParamSink2([]);
new C().decoratedParamSink(source()); // OK - parameter decorators can't be used to mark the parameter as a sink
new C().decoratedParamSink2([]); // OK

5
javascript/ql/test/library-tests/frameworks/data/test.expected
View File

@@ -1,9 +1,6 @@
consistencyIssue
| library-tests/frameworks/data/paramDecorator.ts:11 | did not expect an alert, but found an alert for BasicTaintTracking | OK | |
taintFlow
| paramDecorator.ts:6:54:6:54 | x | paramDecorator.ts:7:10:7:10 | x |
| paramDecorator.ts:12:12:12:19 | source() | paramDecorator.ts:11:51:11:51 | x |
| paramDecorator.ts:16:28:16:35 | source() | paramDecorator.ts:9:50:9:50 | x |
| test.js:5:30:5:37 | source() | test.js:5:8:5:38 | testlib ... urce()) |
| test.js:6:22:6:29 | source() | test.js:6:8:6:30 | preserv ... urce()) |
| test.js:7:41:7:48 | source() | test.js:7:8:7:49 | require ... urce()) |
@@ -59,8 +56,6 @@ taintFlow
| test.js:187:31:187:31 | x | test.js:189:10:189:10 | x |
| test.js:203:32:203:39 | source() | test.js:203:32:203:39 | source() |
isSink
| paramDecorator.ts:9:50:9:50 | x | test-sink |
| paramDecorator.ts:11:51:11:51 | x | test-sink |
| test.js:54:18:54:25 | source() | test-sink |
| test.js:55:22:55:29 | source() | test-sink |
| test.js:57:24:57:31 | source() | test-sink |