hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Rename SSL configuration and fix PathGraph

Browse Source
This commit is contained in:
Ed Minnix
2023-03-09 17:15:21 -05:00
parent efdfc2d0c3
commit 752620a34d
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/lib/semmle/code/java/security/InsecureLdapAuthQuery.qll
View File

@@ -54,7 +54,7 @@ module BasicAuthFlowConfiguration = DataFlow::Make<BasicAuthFlowConfig>;
/**
* A taint-tracking configuration for `ssl` configuration in LDAP authentication.
*/
private module SslFlowConfig implements DataFlow::ConfigSig {
private module RequiresSslConfig implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node src) {
exists(MethodAccess ma |
isSslEnv(ma) and ma.getQualifier() = src.(PostUpdateNode).getPreUpdateNode().asExpr()
@@ -69,4 +69,4 @@ private module SslFlowConfig implements DataFlow::ConfigSig {
}
}
module SslFlowConfiguration = DataFlow::Make<SslFlowConfig>;
module RequiresSslConfiguration = DataFlow::Make<RequiresSslConfig>;

4
java/ql/src/Security/CWE/CWE-522/InsecureLdapAuth.ql
View File

@@ -14,12 +14,12 @@
import java
import semmle.code.java.security.InsecureLdapAuthQuery
import InsecureLdapAuthQuery::PathGraph
import InsecureUrlFlowConfiguration::PathGraph
from InsecureUrlFlowConfiguration::PathNode source, InsecureUrlFlowConfiguration::PathNode sink
where
InsecureUrlFlowConfiguration::hasFlowPath(source, sink) and
BasicAuthFlowConfiguration::hasFlowTo(sink.getNode()) and
not SslFlowConfiguration::hasFlowTo(sink.getNode())
not RequiresSslConfiguration::hasFlowTo(sink.getNode())
select sink.getNode(), source, sink, "Insecure LDAP authentication from $@.", source.getNode(),
"LDAP connection string"