hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5824 from JLLeitschuh/feat/JLL/guava_first_non_null

Browse Source 
[Java] Add support for com.google.common.base.MoreObjects#firstNonNull
This commit is contained in:
Anders Schack-Mulligen
2021-05-11 09:42:20 +02:00
committed by GitHub
parent 2905bb8b9a dfad1fc740
commit 744c495ac2
4 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/change-notes/2021-05-03-guava-first-non-null.md Normal file
View File

@@ -0,0 +1,2 @@
lgtm,codescanning
* Increase coverage of the Guava framework by adding support for `com.google.common.base.MoreObjects#firstNonNull`.

3
java/ql/src/semmle/code/java/frameworks/guava/Base.qll
View File

@@ -35,7 +35,8 @@ private class GuavaBaseCsv extends SummaryModelCsv {
"com.google.common.base;Splitter;false;splitToList;(CharSequence);;Argument[0];ReturnValue;taint",
"com.google.common.base;Splitter;false;splitToStream;(CharSequence);;Argument[0];ReturnValue;taint",
"com.google.common.base;Splitter$MapSplitter;false;split;(CharSequence);;Argument[0];ReturnValue;taint",
"com.google.common.base;Preconditions;false;checkNotNull;;;Argument[0];ReturnValue;value"
"com.google.common.base;Preconditions;false;checkNotNull;;;Argument[0];ReturnValue;value",
"com.google.common.base;MoreObjects;false;firstNonNull;;;Argument[0..1];ReturnValue;value"
]
}
}

6
java/ql/test/library-tests/frameworks/guava/TestBase.java
View File

@@ -60,4 +60,10 @@ class TestBase {
void test4() {
sink(Preconditions.checkNotNull(taint())); // $numTaintFlow=1
}
void test5() {
sink(MoreObjects.firstNonNull(taint(), taint())); // $numTaintFlow=2
sink(MoreObjects.firstNonNull(null, taint())); // $numTaintFlow=1
sink(MoreObjects.firstNonNull(taint(), null)); // $numTaintFlow=1
}
}

9
java/ql/test/stubs/guava-30.0/com/google/common/base/MoreObjects.java Normal file
View File

@@ -0,0 +1,9 @@
package com.google.common.base;
import org.checkerframework.checker.nullness.qual.Nullable;
public final class MoreObjects {
public static <T> T firstNonNull(@Nullable T first, @Nullable T second) {
return null;
}
}