hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 15:25:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

Rust: Add missing annotations to unreachable test.

Browse Source
This commit is contained in:
Geoffrey White
2024-10-28 10:22:46 +00:00
parent b112a9b31e
commit 72606d5a59
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
rust/ql/test/query-tests/unusedentities/unreachable.rs
View File

@@ -163,7 +163,7 @@ fn unreachable_loop() {
do_something(); // BAD: unreachable code
}
for x in 1..10 {
for x in 1..10 { // BAD: unused value `x`
if cond() {
continue;
do_something(); // BAD: unreachable code
@@ -187,7 +187,7 @@ fn unreachable_paren() {
}
fn unreachable_let_1() {
if let Some(a) = maybe_get_a_number() {
if let Some(a) = maybe_get_a_number() { // BAD: unused value `a`
do_something();
return;
} else {
@@ -196,7 +196,7 @@ fn unreachable_let_1() {
do_something(); // SPURIOUS: unreachable code
if let a = get_a_number() { // (always succeeds)
if let a = get_a_number() { // (always succeeds) BAD: unused value `a`
do_something();
return;
} else {
@@ -207,14 +207,14 @@ fn unreachable_let_1() {
}
fn unreachable_let_2() {
let Some(a) = maybe_get_a_number() else {
let Some(a) = maybe_get_a_number() else { // BAD: unused value `a`
do_something();
return;
};
do_something();
let a = maybe_get_a_number() else { // (always succeeds)
let a = maybe_get_a_number() else { // (always succeeds) BAD: unused value `x`
do_something(); // BAD: unreachable code
return;
};