hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

move electron sink to the customizations file

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2022-01-20 14:07:23 +01:00
parent c09b6691e1
commit 7167e856fe
2 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
javascript/ql/lib/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qll
View File

@@ -119,6 +119,17 @@ module ClientSideUrlRedirect {
}
}
/**
* Improper use of openExternal can be leveraged to compromise the user's host.
* When openExternal is used with untrusted content, it can be leveraged to execute arbitrary commands.
*/
class ElectronShellOpenExternalSink extends Sink {
ElectronShellOpenExternalSink() {
this =
DataFlow::moduleMember("electron", "shell").getAMemberCall("openExternal").getArgument(0)
}
}
/**
* An expression that may be interpreted as the URL of a script.
*/

10
javascript/ql/lib/semmle/javascript/security/dataflow/ClientSideUrlRedirectQuery.qll
View File

@@ -55,13 +55,3 @@ class Configuration extends TaintTracking::Configuration {
guard instanceof HostnameSanitizerGuard
}
}
/**
* Improper use of openExternal can be leveraged to compromise the user's host.
* When openExternal is used with untrusted content, it can be leveraged to execute arbitrary commands.
*/
class ElectronShellOpenExternalSink extends Sink {
ElectronShellOpenExternalSink() {
this = DataFlow::moduleMember("electron", "shell").getAMemberCall("openExternal").getArgument(0)
}
}