mirror of
https://github.com/github/codeql.git
synced 2025-12-16 16:53:25 +01:00
Apply suggestions from code review
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
This commit is contained in:
@@ -263,7 +263,6 @@ class ClassAnnotatedAsThreadSafe extends Class {
|
||||
not m0.isPublic() and
|
||||
c.getCallee().getSourceDeclaration() = m0 and
|
||||
c = e and
|
||||
// consider allowing idempotent monitors
|
||||
not Monitors::locallyMonitors(e, monitor) and
|
||||
m.getDeclaringType() = this
|
||||
)
|
||||
|
||||
@@ -41,7 +41,7 @@ predicate not_fully_monitored_field(
|
||||
cls.has_public_write_access(f)
|
||||
) and
|
||||
msg =
|
||||
"The field $@ is not properly synchronized in that no single monitor covers all accesses, but the class $@ is annotated as @ThreadSafe." and
|
||||
"This field is not properly synchronized in that no single monitor covers all accesses, but the class $@ is annotated as @ThreadSafe." and
|
||||
cls_name = cls.getName()
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user