hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Speedup isGuardedByNode()

Browse Source
This commit is contained in:
Tom Hvitved
2019-02-27 11:46:18 +01:00
parent 72384e57e1
commit 7027cd36c6
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
csharp/ql/src/semmle/code/csharp/controlflow/Guards.qll
View File

@@ -1271,6 +1271,14 @@ module Internal {
exists(ConditionOnExprComparisonConfig c | c.same(sub, guarded.getElement()))
}
pragma[noinline]
private predicate isGuardedByNode2(ControlFlow::Nodes::ElementNode guarded, Ssa::Definition def) {
isGuardedByNode1(guarded, _, _, _) and
exists(BasicBlock bb | bb = guarded.getBasicBlock() |
def = guarded.getElement().(AccessOrCallExpr).getAnSsaQualifier(bb.getANode())
)
}
cached
predicate isGuardedByNode(
ControlFlow::Nodes::ElementNode guarded, Guard g, AccessOrCallExpr sub, AbstractValue v
@@ -1278,11 +1286,7 @@ module Internal {
isGuardedByNode1(guarded, g, sub, v) and
sub = g.getAChildExpr*() and
forall(Ssa::Definition def | def = sub.getAnSsaQualifier(_) |
exists(ControlFlow::Node cfn |
def = guarded.getElement().(AccessOrCallExpr).getAnSsaQualifier(cfn)
|
cfn.getBasicBlock() = guarded.getBasicBlock()
)
isGuardedByNode2(guarded, def)
)
}