mirror of
https://github.com/github/codeql.git
synced 2026-04-19 05:54:00 +02:00
Address review comments
This commit is contained in:
@@ -374,9 +374,6 @@ class MatchExprTree extends PostOrderTree instanceof MatchExpr {
|
||||
or
|
||||
// Edge from the end of each arm to the match expression.
|
||||
last(super.getArm(_).getExpr(), pred, c) and succ = this and completionIsNormal(c)
|
||||
or
|
||||
// Edge from the end of last arm to the match expression.
|
||||
last(super.getLastArm().getExpr(), pred, c) and succ = this and completionIsNormal(c)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -34,7 +34,7 @@ abstract class ConditionalSuccessorImpl extends SuccessorTypeImpl {
|
||||
boolean value;
|
||||
|
||||
bindingset[value]
|
||||
ConditionalSuccessorImpl() { any() }
|
||||
ConditionalSuccessorImpl() { exists(value) }
|
||||
|
||||
/** Gets the Boolean value of this successor. */
|
||||
boolean getValue() { result = value }
|
||||
|
||||
@@ -41,11 +41,6 @@ module Impl {
|
||||
/**
|
||||
* Gets the number of arms of this match expression.
|
||||
*/
|
||||
int getNumberOfArms() { result = count(int i | exists(this.getArm(i))) }
|
||||
|
||||
/**
|
||||
* Gets the last arm of this match expression.
|
||||
*/
|
||||
MatchArm getLastArm() { result = this.getArm(this.getNumberOfArms() - 1) }
|
||||
int getNumberOfArms() { result = this.getMatchArmList().getNumberOfArms() }
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user