hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1883 from jbj/partial-definitions-const

Browse Source 
C++: Don't create partial defs for calls to const functions
This commit is contained in:
Robert Marsh
2019-09-10 12:46:39 -07:00
committed by GitHub
parent 05247849b0 d6fba0ef46
commit 6d8a4388cb
3 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cpp/ql/src/semmle/code/cpp/dataflow/internal/FlowVar.qll
View File

@@ -113,7 +113,12 @@ private module PartialDefinitions {
)
)
} or
TExplicitCallQualifier(Expr qualifier, Call call) { qualifier = call.getQualifier() } or
TExplicitCallQualifier(Expr qualifier) {
exists(Call call |
qualifier = call.getQualifier() and
not call.getTarget().hasSpecifier("const")
)
} or
TReferenceArgument(Expr arg, VariableAccess va) { referenceArgument(va, arg) }
private predicate isInstanceFieldWrite(FieldAccess fa, ControlFlowNode node) {
@@ -128,7 +133,7 @@ private module PartialDefinitions {
PartialDefinition() {
this = TExplicitFieldStoreQualifier(definedExpr, node)
or
this = TExplicitCallQualifier(definedExpr, _) and node = definedExpr
this = TExplicitCallQualifier(definedExpr) and node = definedExpr
or
this = TReferenceArgument(definedExpr, node)
}

15
cpp/ql/test/library-tests/dataflow/partialdefinitions/partialdefinitions.cpp
View File

@@ -14,3 +14,18 @@ void test()
s.x = 1;
s.y.z = 1;
}
struct Int {
int data;
Int(int value) : data(value) { } // Not a partial definition but a `PostUpdateNode`
int getData() const { return data; }
void setData(int value) { data = value; }
};
int getSet() {
Int myInt(1);
myInt.setData(
myInt.getData() + 1 // should not be a partial def
);
return myInt.getData(); // should not be a partial def
}

2
cpp/ql/test/library-tests/dataflow/partialdefinitions/partialdefinitions.expected
View File

@@ -1,3 +1,5 @@
| partialdefinitions.cpp:14:2:14:2 | partial def of s | partialdefinitions.cpp:14:2:14:2 | s | partialdefinitions.cpp:14:2:14:8 | ... = ... |
| partialdefinitions.cpp:15:2:15:2 | partial def of s | partialdefinitions.cpp:15:2:15:2 | s | partialdefinitions.cpp:15:2:15:10 | ... = ... |
| partialdefinitions.cpp:15:4:15:4 | partial def of y | partialdefinitions.cpp:15:4:15:4 | y | partialdefinitions.cpp:15:2:15:10 | ... = ... |
| partialdefinitions.cpp:22:29:22:32 | partial def of this | file://:0:0:0:0 | this | partialdefinitions.cpp:22:29:22:40 | ... = ... |
| partialdefinitions.cpp:27:3:27:7 | partial def of myInt | partialdefinitions.cpp:27:3:27:7 | myInt | partialdefinitions.cpp:27:3:27:7 | myInt |