hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 19:26:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6725 from emilejq/date-format

Browse Source 
Java: Remove requirements for final and access mods from DateFormatThreadUnsafe
This commit is contained in:
Anders Schack-Mulligen
2021-09-23 15:02:17 +02:00
committed by GitHub
parent f14e3f6007 83fb41e414
commit 6be4b3bac6
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.java
View File

@@ -1,5 +1,5 @@
class DateFormattingThread implements Runnable { class DateFormattingThread implements Runnable {
private static DateFormat dateF = new SimpleDateFormat("yyyyMMdd"); // Static field declared public static DateFormat dateF = new SimpleDateFormat("yyyyMMdd"); // Static field declared
public void run() { public void run() {
for(int i=0; i < 10; i++){ for(int i=0; i < 10; i++){

1
java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.ql
View File

@@ -16,7 +16,6 @@ import java
from Field f, Class dateFormat from Field f, Class dateFormat
where where
f.isStatic() and f.isStatic() and
f.isFinal() and
(f.isPublic() or f.isProtected()) and (f.isPublic() or f.isProtected()) and
dateFormat.hasQualifiedName("java.text", "DateFormat") and dateFormat.hasQualifiedName("java.text", "DateFormat") and
f.getType().(RefType).hasSupertype*(dateFormat) and f.getType().(RefType).hasSupertype*(dateFormat) and