diff --git a/java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.java b/java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.java index 36576b00c22..f077fb83b9d 100644 --- a/java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.java +++ b/java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.java @@ -1,5 +1,5 @@ class DateFormattingThread implements Runnable { - private static DateFormat dateF = new SimpleDateFormat("yyyyMMdd"); // Static field declared + public static DateFormat dateF = new SimpleDateFormat("yyyyMMdd"); // Static field declared public void run() { for(int i=0; i < 10; i++){ diff --git a/java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.ql b/java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.ql index 19da60422c8..ef3814014ee 100644 --- a/java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.ql +++ b/java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.ql @@ -16,7 +16,6 @@ import java from Field f, Class dateFormat where f.isStatic() and - f.isFinal() and (f.isPublic() or f.isProtected()) and dateFormat.hasQualifiedName("java.text", "DateFormat") and f.getType().(RefType).hasSupertype*(dateFormat) and