hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 23:35:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
This commit is contained in:
Alvaro Muñoz
2023-02-03 16:20:21 +01:00
committed by GitHub
parent c7637a7e1f
commit 6b3d458865
1 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
go/ql/lib/semmle/go/frameworks/Twirp.qll
View File

@@ -160,21 +160,17 @@ module Twirp {
}
}
/**
* A request coming to the service handler
* A request coming to the service handler.
*/
class Request extends UntrustedFlowSource::Range, DataFlow::ParameterNode {
ServiceHandler handler;
class Request extends UntrustedFlowSource::Range instanceof DataFlow::ParameterNode {
Request() {
handler.getParameter(0).getType().hasQualifiedName("context", "Context") and
handler.getParameter(_) = this.asParameter() and
this.getType().(PointerType).getBaseType() instanceof ProtobufMessageType
}
override predicate isParameterOf(Callable c, int i) {
c.asFunction() = handler and
i = 1
exists(Callable c, ServiceHandler handler | c.asFunction() = handler |
this.isParameterOf(c, 1) and
handler.getParameterType(0).hasQualifiedName("context", "Context") and
this.getType().(PointerType).getBaseType() instanceof ProtobufMessageType
)
}
}
}