hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 02:35:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4781 from hvitved/csharp/persisten-cookie-tests

Browse Source 
C#: Add tests for `PersistentCookie.ql`
This commit is contained in:
Tom Hvitved
2020-12-07 11:37:16 +01:00
committed by GitHub
parent b5ec26d935 5d73566859
commit 6a55a22f18
4 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
csharp/ql/test/query-tests/Security Features/CWE-539/PersistentCookie/PersistentCookie.cs Normal file
View File

@@ -0,0 +1,12 @@
// semmle-extractor-options: ${testdir}/../../../../resources/stubs/System.Web.cs /r:System.Collections.Specialized.dll
using System;
class PersistentCookie
{
void M(System.Web.HttpCookie cookie)
{
cookie.Expires = DateTime.Now.AddMonths(12); // BAD
cookie.Expires = DateTime.Now.AddMinutes(3); // GOOD
cookie.Expires = DateTime.Now.AddSeconds(301); // BAD
}
}

2
csharp/ql/test/query-tests/Security Features/CWE-539/PersistentCookie/PersistentCookie.expected Normal file
View File

@@ -0,0 +1,2 @@
| PersistentCookie.cs:8:9:8:51 | ... = ... | Avoid persistent cookies. |
| PersistentCookie.cs:10:9:10:53 | ... = ... | Avoid persistent cookies. |

1
csharp/ql/test/query-tests/Security Features/CWE-539/PersistentCookie/PersistentCookie.qlref Normal file
View File

@@ -0,0 +1 @@
Security Features/PersistentCookie.ql

1
csharp/ql/test/resources/stubs/System.Web.cs
View File

@@ -183,6 +183,7 @@ namespace System.Web
public NameValueCollection Values => null;
public string this[string s] { get => null; set { } }
public bool Secure { get; set; }
public System.DateTime Expires { get; set; }
}
public abstract class HttpCookieCollection : System.Collections.Specialized.NameObjectCollectionBase