hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review comment

Browse Source
This commit is contained in:
Tom Hvitved
2018-09-04 16:07:49 +02:00
parent 9a7746e9b5
commit 6a4dbfce8f
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
csharp/ql/src/semmle/code/csharp/dataflow/SSA.qll
View File

@@ -119,11 +119,11 @@ module Ssa {
ad.getAControlFlowNode() = bb.getNode(i)
and
// In cases like `(x, x) = (0, 1)`, we discard the first (dead) definition of `x`
not exists(TupleAssignmentDefinition tdef, TupleAssignmentDefinition other |
tdef = ad |
other.getAssignment() = tdef.getAssignment() and
other.getEvaluationOrder() > tdef.getEvaluationOrder() and
other = v.getADefinition()
not exists(TupleAssignmentDefinition first, TupleAssignmentDefinition second |
first = ad |
second.getAssignment() = first.getAssignment() and
second.getEvaluationOrder() > first.getEvaluationOrder() and
second = v.getADefinition()
)
and
// In cases like `M(out x, out x)`, there is no inherent evaluation order, so we

10
csharp/ql/src/semmle/code/csharp/dataflow/internal/BaseSSA.qll
View File

@@ -27,11 +27,11 @@ module BaseSsa {
bb.getNode(i) = def.getAControlFlowNode() and
v = def.getTarget() and
// In cases like `(x, x) = (0, 1)`, we discard the first (dead) definition of `x`
not exists(TupleAssignmentDefinition tdef, TupleAssignmentDefinition other |
tdef = def |
other.getAssignment() = tdef.getAssignment() and
other.getEvaluationOrder() > tdef.getEvaluationOrder() and
other.getTarget() = v
not exists(TupleAssignmentDefinition first, TupleAssignmentDefinition second |
first = def |
second.getAssignment() = first.getAssignment() and
second.getEvaluationOrder() > first.getEvaluationOrder() and
second.getTarget() = v
)
}