hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 08:43:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20555 from michaelnebel/csharp/staridlocationsbuildless

Browse Source 
C#: `*` on Source locations in BMN.
This commit is contained in:
Michael Nebel
2025-10-22 13:28:11 +02:00
committed by GitHub
parent 50e0ca8cb4 9ec0c9d5f2
commit 6a02649334
2 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
csharp/extractor/Semmle.Extraction.CSharp/Entities/Locations/NonGeneratedSourceLocation.cs
View File

@@ -40,8 +40,29 @@ namespace Semmle.Extraction.CSharp.Entities
get;
}
private static void WriteStarId(EscapingTextWriter writer)
{
writer.Write('*');
}
public sealed override void WriteQuotedId(EscapingTextWriter writer)
{
if (Context.ExtractionContext.IsStandalone)
{
WriteStarId(writer);
return;
}
base.WriteQuotedId(writer);
}
public override void WriteId(EscapingTextWriter trapFile)
{
if (Context.ExtractionContext.IsStandalone)
{
WriteStarId(trapFile);
return;
}
trapFile.Write("loc,");
trapFile.WriteSubId(FileEntity);
trapFile.Write(',');

4
csharp/ql/lib/change-notes/2025-10-10-starid-locations.md Normal file
View File

@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The extraction of location information for source code entities has been updated to use star IDs (`*` IDs). This change should be transparent to end-users but may improve extraction performance in some cases by reducing TRAP file size and eliminating overhead from location de-duplication.