hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 22:32:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor DataFlow::FunctionNode as a concrete class

Browse Source 
This makes it easier to refine FunctionNode without having to define abstract members.
This commit is contained in:
Chris Smowton
2020-10-01 14:06:52 +01:00
parent 1be34c0c90
commit 68bb7b02fe
1 changed files with 41 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
ql/src/semmle/go/dataflow/internal/DataFlowUtil.qll
View File

@@ -216,10 +216,43 @@ class SsaNode extends Node, MkSsaNode {
}
}
private module FunctionNode {
/** A function, viewed as a node in a data flow graph. */
abstract class Range extends Node {
/** Gets the `i`th parameter of this function. */
abstract ParameterNode getParameter(int i);
/** Gets the name of this function, if it has one. */
abstract string getName();
/**
* Gets the dataflow node holding the value of the receiver, if any.
*/
abstract ReceiverNode getReceiver();
/**
* Gets a value returned by the given function via a return statement or an assignment to a
* result variable.
*/
abstract ResultNode getAResult();
/**
* Gets the function entity this node corresponds to.
*
* Note that this predicate has no result for function literals.
*/
Function getFunction() { none() }
}
}
/** A function, viewed as a node in a data flow graph. */
abstract class FunctionNode extends Node {
class FunctionNode extends Node {
FunctionNode::Range self;
FunctionNode() { this = self }
/** Gets the `i`th parameter of this function. */
abstract ParameterNode getParameter(int i);
ParameterNode getParameter(int i) { result = self.getParameter(i) }
/** Gets a parameter of this function. */
ParameterNode getAParameter() { result = this.getParameter(_) }
@@ -228,18 +261,18 @@ abstract class FunctionNode extends Node {
int getNumParameter() { result = count(this.getAParameter()) }
/** Gets the name of this function, if it has one. */
abstract string getName();
string getName() { result = self.getName() }
/**
* Gets the dataflow node holding the value of the receiver, if any.
*/
abstract ReceiverNode getReceiver();
ReceiverNode getReceiver() { result = self.getReceiver() }
/**
* Gets a value returned by the given function via a return statement or an assignment to a
* result variable.
*/
abstract ResultNode getAResult();
ResultNode getAResult() { result = self.getAResult() }
/**
* Gets the data-flow node corresponding to the `i`th result of this function.
@@ -251,11 +284,11 @@ abstract class FunctionNode extends Node {
*
* Note that this predicate has no result for function literals.
*/
Function getFunction() { none() }
Function getFunction() { result = self.getFunction() }
}
/** A representation of a function that is declared in the module scope. */
class GlobalFunctionNode extends FunctionNode, MkGlobalFunctionNode {
class GlobalFunctionNode extends FunctionNode::Range, MkGlobalFunctionNode {
Function func;
GlobalFunctionNode() { this = MkGlobalFunctionNode(func) }
@@ -284,7 +317,7 @@ class GlobalFunctionNode extends FunctionNode, MkGlobalFunctionNode {
}
/** A representation of the function that is defined by a function literal. */
class FuncLitNode extends FunctionNode, ExprNode {
class FuncLitNode extends FunctionNode::Range, ExprNode {
override FuncLit expr;
override ParameterNode getParameter(int i) { result = parameterNode(expr.getParameter(i)) }