hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix accessibility modifier stubbing

Browse Source
This commit is contained in:
Tamas Vajk
2021-04-15 16:31:47 +02:00
parent 1aadd3f3d6
commit 66eca53b00
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
csharp/ql/src/Stubs/Stubs.qll
View File

@@ -81,10 +81,6 @@ abstract private class GeneratedType extends ValueOrRefType, GeneratedElement {
min(this.getLocation().toString()) + "`\n"
}
private string stubAccessibilityModifier() {
if this.isPublic() then result = "public " else result = ""
}
/** Gets the entire C# stub code for this type. */
final string getStub() {
if this.isDuplicate()
@@ -93,15 +89,14 @@ abstract private class GeneratedType extends ValueOrRefType, GeneratedElement {
not this instanceof DelegateType and
result =
this.stubComment() + this.stubAttributes() + this.stubAbstractModifier() +
this.stubStaticModifier() + this.stubAccessibilityModifier() + this.stubKeyword() + " " +
this.stubStaticModifier() + stubAccessibility(this) + this.stubKeyword() + " " +
this.getUndecoratedName() + stubGenericArguments(this) + stubBaseTypesString() +
stubTypeParametersConstraints(this) + "\n{\n" + stubMembers() + "}\n\n"
or
result =
this.stubComment() + this.stubAttributes() + this.stubAccessibilityModifier() +
this.stubKeyword() + " " + stubClassName(this.(DelegateType).getReturnType()) + " " +
this.getUndecoratedName() + stubGenericArguments(this) + "(" + stubParameters(this) +
");\n\n"
this.stubComment() + this.stubAttributes() + stubAccessibility(this) + this.stubKeyword() +
" " + stubClassName(this.(DelegateType).getReturnType()) + " " + this.getUndecoratedName()
+ stubGenericArguments(this) + "(" + stubParameters(this) + ");\n\n"
)
}
@@ -273,7 +268,13 @@ private string stubAccessibility(Member m) {
then result = "public "
else
if m.isProtected()
then result = "protected "
then
if m.isPrivate()
then result = "protected private "
else
if m.isInternal()
then result = "protected internal "
else result = "protected "
else
if m.isPrivate()
then result = "private "