hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Swift: Rewrite bits to try and get rid of red highlighting.

Browse Source
This commit is contained in:
Geoffrey White
2022-12-02 18:25:39 +00:00
parent 17244734d0
commit 64fb98e46f
2 changed files with 34 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
swift/ql/test/library-tests/dataflow/flowsources/FlowSources.expected
View File

@@ -1,25 +1,25 @@
| alamofire.swift:91:27:91:27 | .result | external |
| alamofire.swift:99:27:99:27 | .result | external |
| alamofire.swift:342:23:342:32 | .data | external |
| alamofire.swift:349:22:349:31 | .value | external |
| alamofire.swift:356:23:356:32 | .value | external |
| alamofire.swift:363:22:363:31 | .value | external |
| alamofire.swift:370:23:370:32 | .value | external |
| alamofire.swift:377:28:377:37 | .value | external |
| alamofire.swift:387:28:387:28 | call to init(contentsOfFile:) | external |
| alamofire.swift:387:28:387:55 | call to init(contentsOfFile:) | external |
| alamofire.swift:394:22:394:31 | .value | external |
| alamofire.swift:401:22:401:31 | .value | external |
| alamofire.swift:402:28:402:28 | call to init(contentsOf:) | external |
| alamofire.swift:402:28:402:50 | call to init(contentsOf:) | external |
| alamofire.swift:409:23:409:32 | .value | external |
| alamofire.swift:416:22:416:31 | .value | external |
| alamofire.swift:423:23:423:32 | .value | external |
| alamofire.swift:429:28:429:37 | .value | external |
| alamofire.swift:446:20:446:20 | call to init(contentsOfFile:) | external |
| alamofire.swift:446:20:446:49 | call to init(contentsOfFile:) | external |
| alamofire.swift:453:23:453:32 | .data | external |
| alamofire.swift:459:23:459:32 | .data | external |
| alamofire.swift:344:23:344:32 | .data | external |
| alamofire.swift:351:22:351:31 | .value | external |
| alamofire.swift:358:23:358:32 | .value | external |
| alamofire.swift:365:22:365:31 | .value | external |
| alamofire.swift:372:23:372:32 | .value | external |
| alamofire.swift:379:28:379:37 | .value | external |
| alamofire.swift:389:28:389:28 | call to init(contentsOfFile:) | external |
| alamofire.swift:389:28:389:55 | call to init(contentsOfFile:) | external |
| alamofire.swift:396:22:396:31 | .value | external |
| alamofire.swift:403:22:403:31 | .value | external |
| alamofire.swift:404:28:404:28 | call to init(contentsOf:) | external |
| alamofire.swift:404:28:404:50 | call to init(contentsOf:) | external |
| alamofire.swift:411:23:411:32 | .value | external |
| alamofire.swift:418:22:418:31 | .value | external |
| alamofire.swift:425:23:425:32 | .value | external |
| alamofire.swift:431:28:431:37 | .value | external |
| alamofire.swift:448:20:448:20 | call to init(contentsOfFile:) | external |
| alamofire.swift:448:20:448:49 | call to init(contentsOfFile:) | external |
| alamofire.swift:455:23:455:32 | .data | external |
| alamofire.swift:461:23:461:32 | .data | external |
| customurlschemes.swift:30:44:30:54 | url | external |
| customurlschemes.swift:34:52:34:68 | url | external |
| customurlschemes.swift:38:52:38:62 | url | external |

26
swift/ql/test/library-tests/dataflow/flowsources/alamofire.swift
View File

@@ -332,7 +332,9 @@ struct MyStreamSerializer: DataStreamSerializer {
struct MyDecodable: Decodable {
}
func doSomething(_ p: Any) {}
func doSomethingWith(_ param: Any) {
// ...
}
func testAlamofire() {
// requests
@@ -469,11 +471,11 @@ func testAlamofire() {
case let .stream(result):
switch result {
case let .success(data): // SOURCE [NOT DETECTED]
doSomething(data)
doSomethingWith(data)
// ...
}
case let .complete(completion):
doSomething(completion)
doSomethingWith(completion)
// ...
}
}
@@ -484,11 +486,11 @@ func testAlamofire() {
case let .stream(result):
switch result {
case let .success(value): // SOURCE [NOT DETECTED]
doSomething(value)
doSomethingWith(value)
// ...
}
case let .complete(completion):
doSomething(completion)
doSomethingWith(completion)
// ...
}
}
@@ -499,11 +501,11 @@ func testAlamofire() {
case let .stream(result):
switch result {
case let .success(value): // SOURCE [NOT DETECTED]
doSomething(value)
doSomethingWith(value)
// ...
}
case let .complete(completion):
doSomething(completion)
doSomethingWith(completion)
// ...
}
}
@@ -514,11 +516,11 @@ func testAlamofire() {
case let .stream(result):
switch result {
case let .success(value): // SOURCE [NOT DETECTED]
doSomething(value)
doSomethingWith(value)
// ...
}
case let .complete(completion):
doSomething(completion)
doSomethingWith(completion)
// ...
}
}
@@ -529,7 +531,7 @@ func testAlamofire() {
stream in
if case let .stream(myResult) = stream.event {
if case let .success(myData) = myResult { // SOURCE [NOT DETECTED]
doSomething(myData)
doSomethingWith(myData)
}
}
}
@@ -537,7 +539,7 @@ func testAlamofire() {
AF.streamRequest("http://example.com/").responseStream {
stream in
if case let .stream(myResult) = stream.event {
doSomething(myResult.success!) // SOURCE [NOT DETECTED]
doSomethingWith(myResult.success!) // SOURCE [NOT DETECTED]
}
}
@@ -546,6 +548,6 @@ func testAlamofire() {
let myResult = Result<String, Error>.success("data")
if case let .success(myString) = myResult {
doSomething(myString)
doSomethingWith(myString)
}
}