hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 22:32:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant taint-tracking from MarshalingFunction and UnmarshalingFunction classes in EncodingXml module.

Browse Source
This commit is contained in:
Slavomir
2020-09-09 14:20:17 +02:00
parent 947bbabf62
commit 64a61bd648
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ql/src/semmle/go/frameworks/stdlib/EncodingXml.qll
View File

@@ -7,16 +7,12 @@ import go
/** Provides models of commonly used functions in the `encoding/xml` package. */
module EncodingXml {
/** The `Marshal` or `MarshalIndent` function in the `encoding/xml` package. */
class MarshalFunction extends TaintTracking::FunctionModel, MarshalingFunction::Range {
private class MarshalFunction extends MarshalingFunction::Range {
MarshalFunction() {
this.hasQualifiedName("encoding/xml", "Marshal") or
this.hasQualifiedName("encoding/xml", "MarshalIndent")
}
override predicate hasTaintFlow(FunctionInput inp, FunctionOutput outp) {
inp = getAnInput() and outp = getOutput()
}
override FunctionInput getAnInput() { result.isParameter(0) }
override FunctionOutput getOutput() { result.isResult(0) }
@@ -24,13 +20,9 @@ module EncodingXml {
override string getFormat() { result = "XML" }
}
private class UnmarshalFunction extends TaintTracking::FunctionModel, UnmarshalingFunction::Range {
private class UnmarshalFunction extends UnmarshalingFunction::Range {
UnmarshalFunction() { this.hasQualifiedName("encoding/xml", "Unmarshal") }
override predicate hasTaintFlow(FunctionInput inp, FunctionOutput outp) {
inp = getAnInput() and outp = getOutput()
}
override FunctionInput getAnInput() { result.isParameter(0) }
override FunctionOutput getOutput() { result.isParameter(1) }