Apply changes from code review

This commit is contained in:
edvraa
2021-07-12 01:06:27 +03:00
parent 3de7b280e4
commit 6393dca22f

View File

@@ -52,7 +52,6 @@ class CookieOptionsTrackingConfiguration extends DataFlow::Configuration {
override predicate isSink(DataFlow::Node sink) {
exists(MicrosoftAspNetCoreHttpResponseCookies iResponse, MethodCall mc |
iResponse.getAppendMethod() = mc.getTarget() and
mc.getNumberOfArguments() > 2 and
mc.getArgument(2) = sink.asExpr()
)
}
@@ -144,7 +143,7 @@ class OnAppendCookieHttpOnlyTrackingConfig extends OnAppendCookieTrackingConfig
/**
* Tracks if a callback used in `OnAppendCookie` sets a cookie property to `true`.
*/
abstract class OnAppendCookieTrackingConfig extends DataFlow::Configuration {
private abstract class OnAppendCookieTrackingConfig extends DataFlow::Configuration {
bindingset[this]
OnAppendCookieTrackingConfig() { any() }