hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 10:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Swift: Delete one TODO (it has been converted to an internal issue) and fix another.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-10-26 21:48:41 +01:00
parent 784bb72b33
commit 63525a9d9e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll
View File

@@ -918,7 +918,6 @@ private module CaptureInput implements VariableCapture::InputSig {
variable = np.getVarDecl() and
source = np.getMatchingExpr()
)
// TODO: support multiple variables in LHS of =, in both of above cases.
}
CapturedVariable getVariable() { result = variable }
@@ -929,7 +928,7 @@ private module CaptureInput implements VariableCapture::InputSig {
class VariableRead extends Expr instanceof S::DeclRefExpr {
CapturedVariable v;
VariableRead() { this.getDecl() = v /* TODO: this should be an R-value only. */ }
VariableRead() { this.getDecl() = v and not isLValue(this) }
CapturedVariable getVariable() { result = v }
}