hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rename confusing predicate and add qldoc

Browse Source
This commit is contained in:
Owen Mansel-Chan
2025-09-25 12:33:42 +01:00
parent b1bcbec37d
commit 630a8446ad
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
go/ql/lib/semmle/go/dataflow/internal/TaintTrackingUtil.qll
View File

@@ -109,7 +109,13 @@ private predicate localAdditionalForwardTaintStep(
.getSummaryNode(), succ.(DataFlowPrivate::FlowSummaryNode).getSummaryNode(), false, model)
}
private predicate localForwardTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
/**
* This is a helper predicate for `localAdditionalBackwardTaintStep`. It mixes
* local data flow with local forward taint steps. It should only ever be used
* via its transitive closure, which gives local forward taint flow, that is
* with backward steps excluded.
*/
private predicate partialLocalForwardTaintFlow(DataFlow::Node pred, DataFlow::Node succ) {
DataFlow::localFlow(pred, succ) or
localAdditionalForwardTaintStep(pred, succ, _) or
// Simple flow through library code is included in the exposed local
@@ -126,7 +132,7 @@ private predicate localAdditionalBackwardTaintStep(
// backward step through function model
exists(FunctionModel m, DataFlow::Node resultNode |
m.backwardTaintStep(resultNode, succ) and
localForwardTaintStep+(resultNode, pred.(DataFlow::PostUpdateNode).getPreUpdateNode())
partialLocalForwardTaintFlow+(resultNode, pred.(DataFlow::PostUpdateNode).getPreUpdateNode())
) and
model = "FunctionModel"
}