hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 16:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14204 from hvitved/ruby/simplify-viable-callable

Browse Source 
Ruby: Simplify `viableSourceCallableNonInit`
This commit is contained in:
Tom Hvitved
2023-09-14 15:36:47 +02:00
committed by GitHub
parent 6ce7a56b41 f15cbb9316
commit 61bfc4ec09
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowDispatch.qll
View File

@@ -309,8 +309,14 @@ predicate isUserDefinedNew(SingletonMethod new) {
}
private Callable viableSourceCallableNonInit(RelevantCall call) {
result = getTarget(call) and
not result = blockCall(call) // handled by `lambdaCreation`/`lambdaCall`
result = getTargetInstance(call, _)
or
result = getTargetSingleton(call, _)
or
exists(Module cls, string method |
superCall(call, cls, method) and
result = lookupMethod(cls.getAnImmediateAncestor(), method)
)
}
private Callable viableSourceCallableInit(RelevantCall call) { result = getInitializeTarget(call) }
@@ -400,14 +406,7 @@ private module Cached {
cached
CfgScope getTarget(RelevantCall call) {
result = getTargetInstance(call, _)
or
result = getTargetSingleton(call, _)
or
exists(Module cls, string method |
superCall(call, cls, method) and
result = lookupMethod(cls.getAnImmediateAncestor(), method)
)
result = viableSourceCallableNonInit(call)
or
result = blockCall(call)
}