C#: Include dup instructions in CIL ExprMissingType consistency test

2026-04-30 03:05:15 +02:00 · 2021-12-06 14:37:07 +01:00
parent 6b1ac73a46
commit 60c0bcf8f7
2 changed files with 13 additions and 1 deletions
--- a/csharp/ql/lib/semmle/code/cil/ConsistencyChecks.qll
+++ b/csharp/ql/lib/semmle/code/cil/ConsistencyChecks.qll
@@ -612,7 +612,7 @@ class ExprMissingType extends InstructionViolation {
    not instruction instanceof Opcodes::Ldvirtftn and
    not instruction instanceof Opcodes::Arglist and
    not instruction instanceof Opcodes::Refanytype and
-    instruction.getPushCount() = 1 and
+    instruction.getPushCount() >= 1 and
    count(instruction.getType()) != 1
  }

--- a/csharp/ql/test/library-tests/cil/consistency/consistency.expected
+++ b/csharp/ql/test/library-tests/cil/consistency/consistency.expected