Merge pull request #860 from calumgrant/cs/library-flow

C#: Refactor LibraryTypeDataFlow
2026-04-30 11:15:13 +02:00 · 2019-02-07 11:52:05 +01:00
parent 4274bb136f ce7e9901cc
commit 5f027e1761
2 changed files with 252 additions and 260 deletions
--- a/Abuse/ForeachCapture.ql
+++ b/Abuse/ForeachCapture.ql
@@ -82,7 +82,6 @@ Element getCollectionAssignmentTarget(Expr e) {
    ief = mc.getQualifier().getType().getSourceDeclaration() and
    m = mc.getTarget().getSourceDeclaration() and
    ief.callableFlow(source, sink, m, _) and
-    source.getCallable() = m and
    source.getArgumentIndex() = i and
    e = mc.getArgument(i)
  )
--- a/csharp/ql/src/semmle/code/csharp/dataflow/LibraryTypeDataFlow.qll
+++ b/csharp/ql/src/semmle/code/csharp/dataflow/LibraryTypeDataFlow.qll