hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Address review comments

Browse Source
This commit is contained in:
Asger F
2019-06-27 23:46:15 +01:00
parent 408fd3e106
commit 5ce08e2c78
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/src/semmle/javascript/dataflow/Nodes.qll
View File

@@ -868,7 +868,7 @@ module ClassNode {
result = getAPrototypeReference().getAPropertySource(name)
or
kind = MemberKind::method() and
result = getConstructor().getReceiver().getAPropertyWrite(name).getRhs().getALocalSource()
result = getConstructor().getReceiver().getAPropertySource(name)
or
exists(PropertyAccessor accessor |
accessor = getAnAccessor(kind) and

6
javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll
View File

@@ -102,11 +102,11 @@ private module CachedSteps {
* or one of its super classes.
*/
cached
predicate callResolvesToClass(DataFlow::InvokeNode invoke, DataFlow::ClassNode cls, string name) {
predicate callResolvesToMember(DataFlow::InvokeNode invoke, DataFlow::ClassNode cls, string name) {
invoke = cls.getAnInstanceReference().getAMethodCall(name)
or
exists(DataFlow::ClassNode subclass |
callResolvesToClass(invoke, subclass, name) and
callResolvesToMember(invoke, subclass, name) and
not exists(subclass.getAnInstanceMember(name)) and
cls = subclass.getADirectSuperClass()
)
@@ -120,7 +120,7 @@ private module CachedSteps {
f = invk.getACallee(0)
or
exists(DataFlow::ClassNode cls, string name |
callResolvesToClass(invk, cls, name) and
callResolvesToMember(invk, cls, name) and
f = cls.getInstanceMethod(name).getFunction()
)
}