hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-06-06 05:57:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix treatment of ParenExpr

Browse Source
This commit is contained in:
Owen Mansel-Chan
2026-06-03 14:01:20 +01:00
parent 996a936f85
commit 5c91529b92
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
go/ql/lib/semmle/go/controlflow/ControlFlowGraphShared.qll
View File

@@ -60,8 +60,6 @@ module GoCfg {
not e = any(Go::IndexExpr idx).getBase() and
not e = any(Go::IndexExpr idx).getIndex()
or
e instanceof Go::ParenExpr
or
e instanceof Go::CommentGroup
or
e instanceof Go::Comment
@@ -75,9 +73,7 @@ module GoCfg {
not n instanceof Go::FuncDef and
not skipCfg(n) and
not skipCfg(result) and
exists(Go::AstNode c | c = n.getChild(index) |
if c instanceof Go::ParenExpr then result = c.(Go::ParenExpr).stripParens() else result = c
)
result = n.getChild(index)
}
class Callable extends AstNode {
@@ -352,6 +348,10 @@ module GoCfg {
predicate preOrderExpr(Ast::Expr e) { none() }
predicate propagatesValue(Ast::AstNode child, Ast::AstNode parent) {
child = parent.(Go::ParenExpr).getExpr()
}
predicate postOrInOrder(Ast::AstNode n) {
n instanceof Go::ReferenceExpr
or