TS: Add workaround for 'globalThis' getProperties() crash

javascript/extractor/lib/typescript/src/type_table.ts

@@ -819,8 +819,24 @@ export class TypeTable {
     this.isInShallowTypeContext = false;
   }
 
+  /**
+   * Returns the properties of the given type, or `null` if the properties of this
+   * type could not be computed.
+   */
+  private tryGetProperties(type: ts.Type) {
+    // Workaround for https://github.com/Microsoft/TypeScript/issues/30845
+    // Should be safe to remove once that has been fixed.
+    try {
+      return type.getProperties();
+    } catch (e) {
+      return null;
+    }
+  }
+
   private extractProperties(type: ts.Type, id: number) {
-    for (let symbol of type.getProperties()) {
+    let props = this.tryGetProperties(type);
+    if (props == null) return;
+    for (let symbol of props) {
       let propertyType = this.typeChecker.getTypeOfSymbolAtLocation(symbol, this.arbitraryAstNode);
       if (propertyType == null) continue;
       let propertyTypeId = this.getId(propertyType);

javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/test.expected

@@ -0,0 +1 @@
+| Success |

javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/test.ql

@@ -0,0 +1,3 @@
+import javascript
+
+select "Success"

javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/tsconfig.json

@@ -0,0 +1,3 @@
+{
+  "include": ["."]
+}

javascript/ql/test/library-tests/TypeScript/RegressionTests/GlobalThis/tst.ts

@@ -0,0 +1,13 @@
+'use strict';
+
+var _myGlobal = this;
+
+module Test {
+  var global = _myGlobal || {};
+
+  export class C {}
+
+  export function f(x: C) {
+    global.field = x || {};
+  }
+}