hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Documentation changes

Browse Source
This commit is contained in:
Ed Minnix
2023-03-08 22:16:44 -05:00
parent 0f4709e769
commit 59ce0d7682
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/lib/semmle/code/java/security/InsecureLdapAuth.qll
View File

@@ -5,7 +5,7 @@ import semmle.code.java.frameworks.Networking
import semmle.code.java.frameworks.Jndi
/**
* Insecure (non-SSL, non-private) LDAP URL string literal.
* An insecure (non-SSL, non-private) LDAP URL string literal.
*/
class InsecureLdapUrlLiteral extends StringLiteral {
InsecureLdapUrlLiteral() {
@@ -30,7 +30,7 @@ private string getHostname(Expr expr) {
}
/**
* String concatenated with `InsecureLdapUrlLiteral`.
* An expression that represents an insecure (non-SSL, non-private) LDAP URL.
*/
class InsecureLdapUrl extends Expr {
InsecureLdapUrl() {

6
java/ql/lib/semmle/code/java/security/InsecureLdapAuthQuery.qll
View File

@@ -10,10 +10,8 @@ import semmle.code.java.security.InsecureLdapAuth
* A taint-tracking configuration for `ldap://` URL in LDAP authentication.
*/
private module InsecureUrlFlowConfig implements DataFlow::ConfigSig {
/** Source of `ldap://` connection string. */
predicate isSource(DataFlow::Node src) { src.asExpr() instanceof InsecureLdapUrl }
/** Sink of directory context creation. */
predicate isSink(DataFlow::Node sink) {
exists(ConstructorCall cc |
cc.getConstructedType().getAnAncestor() instanceof TypeDirContext and
@@ -37,14 +35,12 @@ module InsecureUrlFlowConfiguration = TaintTracking::Make<InsecureUrlFlowConfig>
* A taint-tracking configuration for `simple` basic-authentication in LDAP configuration.
*/
private module BasicAuthFlowConfig implements DataFlow::ConfigSig {
/** Source of `simple` configuration. */
predicate isSource(DataFlow::Node src) {
exists(MethodAccess ma |
isBasicAuthEnv(ma) and ma.getQualifier() = src.(PostUpdateNode).getPreUpdateNode().asExpr()
)
}
/** Sink of directory context creation. */
predicate isSink(DataFlow::Node sink) {
exists(ConstructorCall cc |
cc.getConstructedType().getAnAncestor() instanceof TypeDirContext and
@@ -59,14 +55,12 @@ module BasicAuthFlowConfiguration = DataFlow::Make<BasicAuthFlowConfig>;
* A taint-tracking configuration for `ssl` configuration in LDAP authentication.
*/
private module SslFlowConfig implements DataFlow::ConfigSig {
/** Source of `ssl` configuration. */
predicate isSource(DataFlow::Node src) {
exists(MethodAccess ma |
isSslEnv(ma) and ma.getQualifier() = src.(PostUpdateNode).getPreUpdateNode().asExpr()
)
}
/** Sink of directory context creation. */
predicate isSink(DataFlow::Node sink) {
exists(ConstructorCall cc |
cc.getConstructedType().getAnAncestor() instanceof TypeDirContext and