hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1168 from geoffw0/format-amp

Browse Source 
CPP: %@ in format strings
This commit is contained in:
Jonas Jensen
2019-03-27 09:08:39 +01:00
committed by GitHub
parent 578ed146ed 1d0c74daa7
commit 581e765f97
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/src/semmle/code/cpp/commons/Printf.qll
View File

@@ -256,11 +256,11 @@ class FormatLiteral extends Literal {
}
/**
* Gets the format string, with '%%' replaced by '_' (to avoid processing
* '%%' as a format specifier).
* Gets the format string, with '%%' and '%@' replaced by '_' (to avoid processing
* them as format specifiers).
*/
string getFormat() {
result = this.getValue().replaceAll("%%", "_")
result = this.getValue().replaceAll("%%", "_").replaceAll("%@", "_")
}
/**

2
cpp/ql/test/query-tests/Likely Bugs/Format/WrongNumberOfFormatArguments/test.c
View File

@@ -40,4 +40,6 @@ void test(int i, const char *str)
printf("%2$.*4$f", 0, num, 0, precision); // GOOD [FALSE POSITIVE]
printf("%2$.*4$f", num, 0, precision); // BAD (too few format arguments) [INCORRECT MESSAGE]
}
printf("%@ %i %i", 1, 2); // GOOD
}