hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-23 07:45:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

Shared: Update type tracking consistency checks

Browse Source
This commit is contained in:
Tom Hvitved
2023-11-15 15:26:15 +01:00
parent 5f087f0084
commit 57f6859ddc
1 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
shared/typetracking/codeql/typetracking/internal/TypeTrackingImpl.qll
View File

@@ -33,10 +33,11 @@ module TypeTracking<TypeTrackingInput I> {
* Holds if there is any node in a step relation that is unreachable from a
* `LocalSourceNode`.
*/
query predicate unreachableNode(string msg) {
exists(int k, string kind |
k = strictcount(Node n | stepEntry(n, kind) and not flowsTo(_, n)) and
msg = "There are " + k + " unreachable nodes in steps of kind " + kind + "."
query predicate unreachableNode(Node n, string msg) {
exists(string kind |
stepEntry(n, kind) and
not flowsTo(_, n) and
msg = "Unreachable node in step of kind " + kind + "."
)
}
@@ -44,18 +45,11 @@ module TypeTracking<TypeTrackingInput I> {
* Holds if there is a store target that isn't a `LocalSourceNode` and
* backtracking store target feature isn't enabled.
*/
query predicate nonSourceStoreTarget(string msg) {
query predicate nonSourceStoreTarget(Node n, string msg) {
not hasFeatureBacktrackStoreTarget() and
exists(int k |
k =
strictcount(Node n |
not n instanceof LocalSourceNode and
(storeStep(_, n, _) or loadStoreStep(_, n, _, _))
) and
msg =
"There are " + k +
" store targets that are not local source nodes and backtracking store targets is not enabled."
)
not n instanceof LocalSourceNode and
(storeStep(_, n, _) or loadStoreStep(_, n, _, _)) and
msg = "Store target is not a local source nodes and backtracking store targets is disabled."
}
}