hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 14:23:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Exclude results in test files

Browse Source
This commit is contained in:
Slavomir
2020-05-12 13:12:47 +03:00
parent e5e74f34d7
commit 556f527193
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ql/src/experimental/CWE-681/IncorrectNumericConversion.ql
View File

@@ -249,9 +249,17 @@ string formatBitSize(ParserCall call) {
from DataFlow::PathNode source, DataFlow::PathNode sink
where
exists(Lt64BitFlowConfig cfg | cfg.hasFlowPath(source, sink)) or
exists(Lt32BitFlowConfig cfg | cfg.hasFlowPath(source, sink)) or
exists(Lt16BitFlowConfig cfg | cfg.hasFlowPath(source, sink))
(
exists(Lt64BitFlowConfig cfg | cfg.hasFlowPath(source, sink))
or
exists(Lt32BitFlowConfig cfg | cfg.hasFlowPath(source, sink))
or
exists(Lt16BitFlowConfig cfg | cfg.hasFlowPath(source, sink))
) and
// Exclude results in test files:
exists(File fl | fl = sink.getNode().asExpr().(NumericConversionExpr).getFile() |
not fl instanceof TestFile
)
select source.getNode(), source, sink,
"Incorrect conversion of a " + formatBitSize(source.getNode().(ParserCall)) + "-bit number from " +
source.getNode().(ParserCall).getParserName() + " result to a lower bit size type " +