hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-30 06:42:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #547 from edoardopirovano/fix-join-order

Browse Source 
Performance: Fix bad join ordering
This commit is contained in:
Chris Smowton
2021-06-21 20:11:22 +01:00
committed by GitHub
parent ac777d237d a7c656db8b
commit 52028cf363
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
ql/src/semmle/go/dataflow/internal/DataFlowUtil.qll
View File

@@ -1163,20 +1163,23 @@ abstract class BarrierGuard extends Node {
* Holds if `guard` markes a point in the control-flow graph where this node
* is known to validate `nd`.
*/
pragma[noopt]
private predicate guards(ControlFlow::ConditionGuardNode guard, Node nd) {
exists(boolean branch |
this.checks(nd.asExpr(), branch) and
exists(boolean branch, Expr expr |
expr = nd.asExpr() and
this.checks(expr, branch) and
guard.ensures(this, branch)
)
or
exists(
Function f, FunctionInput inp, FunctionOutput outp, DataFlow::Property p, CallNode c,
Node resNode, Node check, boolean outcome
Node resNode, Node check, boolean outcome, Node functionOutput
|
guardingFunction(f, inp, outp, p) and
c = f.getACall() and
nd = inp.getNode(c) and
localFlow(outp.getNode(c), resNode) and
functionOutput = outp.getNode(c) and
localFlow(functionOutput, resNode) and
p.checkOn(check, outcome, resNode) and
guard.ensures(check, outcome)
)