hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 12:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

made model of Deferred more precise

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2019-10-09 16:18:04 +02:00
parent c7eb0f17a9
commit 4ec825b5b6
1 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
javascript/ql/src/semmle/javascript/Promises.qll
View File

@@ -37,10 +37,23 @@ module Bluebird {
*/
module Deferred {
private DataFlow::SourceNode deferred() {
exists(VarAccess var, DataFlow::NewNode instantiation |
var.getName() = "Deferred" and
result = DataFlow::exprNode(var).getALocalSource() and
// Sanity check that result really is a Deferred implementation
(
exists(Variable var |
var.getName() = "Deferred" and
(var.getADeclaration() instanceof LocalNamespaceDecl or var.getScope() instanceof GlobalScope) and
result = DataFlow::valueNode(var.getADefinition())
)
or
result.(DataFlow::ParameterNode).getName() = "Deferred"
or
exists(Function f |
f.getName() = "Deferred" and
result = DataFlow::valueNode(f)
)
)
and
// Sanity check that it is a Deferred implementation
exists(DataFlow::NewNode instantiation |
instantiation = result.getAnInstantiation() and
exists(instantiation.getAMemberCall("resolve"))
)