hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-21 15:05:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update C# example

Browse Source
This commit is contained in:
Shati Patel
2020-07-30 10:57:17 +01:00
parent 0a4b828432
commit 4da74dea28
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
docs/language/learn-ql/csharp/basic-query-csharp.rst
View File

@@ -106,12 +106,17 @@ Browsing the results of our basic query shows that it could be improved. Among t
.. code-block:: csharp
if (...) {
...
} else if (string.Compare(option, "-verbose")==0) {
// nothing to do - handled earlier
} else {
error("unrecognized option");
if (...)
{
...
}
else if (option == "-verbose")
{
// nothing to do - handled earlier
}
else
{
error("unrecognized option");
}
In this case, identifying the ``if`` statement with the empty ``then`` branch as redundant is a false positive. One solution to this is to modify the query to ignore empty ``then`` branches if the ``if`` statement has an ``else`` branch.