hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-23 04:06:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1156 from esben-semmle/js/fix-define-property-regression

Browse Source 
JS: fix getAPropertyAttribute timeouts
This commit is contained in:
Max Schaefer
2019-03-25 11:11:58 +00:00
committed by GitHub
parent d6be42dcc7 335a969946
commit 4d1161f236
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll
View File

@@ -496,7 +496,11 @@ module DataFlow {
override string getPropertyName() { result = odp.getPropertyName() } override string getPropertyName() { result = odp.getPropertyName() }
override Node getRhs() { override Node getRhs() {
odp.getAPropertyAttribute().writes(_, "value", result) // not using `CallToObjectDefineProperty::getAPropertyAttribute` for performance reasons
exists(ObjectLiteralNode propdesc |
propdesc.flowsTo(odp.getPropertyDescriptor()) and
propdesc.hasPropertyWrite("value", result)
)
} }
override ControlFlowNode getWriteNode() { result = odp.getAstNode() } override ControlFlowNode getWriteNode() { result = odp.getAstNode() }