Merge pull request #1156 from esben-semmle/js/fix-define-property-regression

JS: fix getAPropertyAttribute timeouts
This commit is contained in:
Max Schaefer
2019-03-25 11:11:58 +00:00
committed by GitHub

View File

@@ -496,7 +496,11 @@ module DataFlow {
override string getPropertyName() { result = odp.getPropertyName() }
override Node getRhs() {
odp.getAPropertyAttribute().writes(_, "value", result)
// not using `CallToObjectDefineProperty::getAPropertyAttribute` for performance reasons
exists(ObjectLiteralNode propdesc |
propdesc.flowsTo(odp.getPropertyDescriptor()) and
propdesc.hasPropertyWrite("value", result)
)
}
override ControlFlowNode getWriteNode() { result = odp.getAstNode() }