hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Rust: Variants inherit visibility from their parent enum

Browse Source
This commit is contained in:
Tom Hvitved
2025-03-31 11:20:18 +02:00
parent f09c3c5813
commit 4b3816e14e
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rust/ql/lib/codeql/rust/internal/PathResolution.qll
View File

@@ -321,7 +321,7 @@ private class VariantItemNode extends ItemNode instanceof Variant {
result = super.getEnum().getGenericParamList().getTypeParam(i)
}
override Visibility getVisibility() { result = Variant.super.getVisibility() }
override Visibility getVisibility() { result = super.getEnum().getVisibility() }
}
class FunctionItemNode extends AssocItemNode instanceof Function {

2
rust/ql/test/library-tests/path-resolution/main.rs
View File

@@ -514,7 +514,7 @@ mod m21 {
};
fn f() {
let _ = MyEnum::A; // $ MISSING: item=I104
let _ = MyEnum::A; // $ item=I104
let _ = MyStruct {}; // $ item=I106
}
}

1
rust/ql/test/library-tests/path-resolution/path-resolution.expected
View File

@@ -232,6 +232,7 @@ resolvePath
| main.rs:512:13:512:32 | ...::MyStruct | main.rs:502:9:502:28 | struct MyStruct |
| main.rs:513:13:513:16 | self | main.rs:502:9:502:28 | struct MyStruct |
| main.rs:517:21:517:26 | MyEnum | main.rs:498:9:500:9 | enum MyEnum |
| main.rs:517:21:517:29 | ...::A | main.rs:499:13:499:13 | A |
| main.rs:518:21:518:28 | MyStruct | main.rs:502:9:502:28 | struct MyStruct |
| main.rs:524:5:524:6 | my | main.rs:1:1:1:7 | mod my |
| main.rs:524:5:524:14 | ...::nested | my.rs:1:1:1:15 | mod nested |