hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-07-31 23:42:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix circular dependency

Browse Source
This commit is contained in:
Owen Mansel-Chan
2026-06-29 11:16:38 +01:00
parent f730c889d9
commit 4aaf7353a4
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
go/ql/lib/semmle/go/controlflow/IR.qll
View File

@@ -1263,8 +1263,20 @@ module IR {
MkLiteralElementTarget(ControlFlow::Node write) {
write.isAdditional(any(CompositeLit lit).getAnElement(), "lit-init")
} or
/** A result variable write target. */
MkResultWriteTarget(WriteResultInstruction w)
/**
* A result variable write target. Parameterized by `ControlFlow::Node`
* rather than `WriteResultInstruction` to avoid a circular dependency:
* `WriteResultInstruction extends WriteInstruction` needs
* `MkResultWriteTarget(this)` to hold, which would in turn require
* `this` to already be a `WriteResultInstruction`.
*/
MkResultWriteTarget(ControlFlow::Node w) {
exists(ReturnStmt ret, int idx |
w.isAdditional(ret, "result-write:" + idx.toString()) and
exists(ret.getEnclosingFunction().getResultVar(idx)) and
exists(ret.getAnExpr())
)
}
/** A representation of the target of a write instruction. */
class WriteTarget extends TWriteTarget {