hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-23 18:33:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++ Suggested code clean up.

Browse Source
This commit is contained in:
REDMOND\brodes
2026-02-12 11:11:43 -05:00
parent c64a6762d0
commit 4a7395b017
1 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification.ql
View File

@@ -233,32 +233,29 @@ class IgnorableAssignmentBitwiseOperation extends IgnorableOperation instanceof
class IgnorablePointerOrCharArithmetic extends IgnorableOperation {
IgnorablePointerOrCharArithmetic() {
this instanceof BinaryArithmeticOperation and
(
this.(BinaryArithmeticOperation).getAnOperand().getUnspecifiedType() instanceof PointerType
exists(Expr op | op = this.(BinaryArithmeticOperation).getAnOperand() |
op.getUnspecifiedType() instanceof PointerType
or
this.(BinaryArithmeticOperation).getAnOperand().getUnspecifiedType() instanceof CharType
op.getUnspecifiedType() instanceof CharType
or
// Operations on calls to functions that accept char or char*
this.(BinaryArithmeticOperation)
.getAnOperand()
.(Call)
.getAnArgument()
.getUnspecifiedType()
.stripType() instanceof CharType
op.(Call).getAnArgument().getUnspecifiedType().stripType() instanceof CharType
or
// Operations on calls to functions named like "strlen", "wcslen", etc
// NOTE: workaround for cases where the wchar_t type is not a char, but an unsigned short
// unclear if there is a best way to filter cases like these out based on type info.
this.(BinaryArithmeticOperation).getAnOperand().(Call).getTarget().getName().matches("%len%")
op.(Call).getTarget().getName().matches("%len%")
)
or
exists(AssignArithmeticOperation a | a.getRValue() = this |
a.getAnOperand().getUnspecifiedType() instanceof PointerType
or
a.getAnOperand().getUnspecifiedType() instanceof CharType
or
// Operations on calls to functions that accept char or char*
a.getAnOperand().(Call).getAnArgument().getUnspecifiedType().stripType() instanceof CharType
exists(Expr op | op = a.getAnOperand() |
op.getUnspecifiedType() instanceof PointerType
or
op.getUnspecifiedType() instanceof CharType
or
// Operations on calls to functions that accept char or char*
op.(Call).getAnArgument().getUnspecifiedType().stripType() instanceof CharType
)
or
// Operations on calls to functions named like "strlen", "wcslen", etc
this.(BinaryArithmeticOperation).getAnOperand().(Call).getTarget().getName().matches("%len%")