hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-06 18:21:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12250 from geoffw0/filemanagersource

Browse Source 
Swift: Taint sources for FileManager
This commit is contained in:
Mathias Vorreiter Pedersen
2023-02-20 09:12:11 +00:00
committed by GitHub
parent efc75e02cc 7a9bbb1414
commit 49be5fd19a
4 changed files with 85 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
swift/ql/lib/codeql/swift/dataflow/ExternalFlow.qll
View File

@@ -81,6 +81,7 @@ private module Frameworks {
private import codeql.swift.frameworks.StandardLibrary.Collection
private import codeql.swift.frameworks.StandardLibrary.CustomUrlSchemes
private import codeql.swift.frameworks.StandardLibrary.Data
private import codeql.swift.frameworks.StandardLibrary.FileManager
private import codeql.swift.frameworks.StandardLibrary.FilePath
private import codeql.swift.frameworks.StandardLibrary.InputStream
private import codeql.swift.frameworks.StandardLibrary.NsData

25
swift/ql/lib/codeql/swift/frameworks/StandardLibrary/FileManager.qll Normal file
View File

@@ -0,0 +1,25 @@
/**
* Provides models for the `FileManager` Swift class.
*/
import swift
private import codeql.swift.dataflow.ExternalFlow
/**
* A model for `FileManager` members that are flow sources.
*/
private class FileManagerSource extends SourceModelCsv {
override predicate row(string row) {
row =
[
";FileManager;true;contentsOfDirectory(at:includingPropertiesForKeys:options:);;;ReturnValue;local",
";FileManager;true;contentsOfDirectory(atPath:);;;ReturnValue;local",
";FileManager;true;directoryContents(atPath:);;;ReturnValue;local",
";FileManager;true;subpathsOfDirectory(atPath:);;;ReturnValue;local",
";FileManager;true;subpaths(atPath:);;;ReturnValue;local",
";FileManager;true;destinationOfSymbolicLink(atPath:);;;ReturnValue;local",
";FileManager;true;pathContentOfSymbolicLink(atPath:);;;ReturnValue;local",
";FileManager;true;contents(atPath:);;;ReturnValue;local"
]
}
}

8
swift/ql/test/library-tests/dataflow/flowsources/FlowSources.expected
View File

@@ -38,6 +38,14 @@
| file://:0:0:0:0 | .source1 | external |
| file://:0:0:0:0 | .source4 | external |
| file://:0:0:0:0 | .source9 | external |
| filemanager.swift:37:23:37:86 | call to contentsOfDirectory(at:includingPropertiesForKeys:options:) | external |
| filemanager.swift:38:23:38:58 | call to contentsOfDirectory(atPath:) | external |
| filemanager.swift:39:19:39:52 | call to directoryContents(atPath:) | external |
| filemanager.swift:41:23:41:58 | call to subpathsOfDirectory(atPath:) | external |
| filemanager.swift:42:19:42:43 | call to subpaths(atPath:) | external |
| filemanager.swift:44:19:44:60 | call to destinationOfSymbolicLink(atPath:) | external |
| filemanager.swift:45:15:45:56 | call to pathContentOfSymbolicLink(atPath:) | external |
| filemanager.swift:47:14:47:38 | call to contents(atPath:) | external |
| generics.swift:10:9:10:16 | .source1 | external |
| generics.swift:11:9:11:16 | .source2 | external |
| generics.swift:12:9:12:24 | call to source3() | external |

51
swift/ql/test/library-tests/dataflow/flowsources/filemanager.swift Normal file
View File

@@ -0,0 +1,51 @@
// --- stubs ---
class NSObject {
}
struct URL {
}
struct URLResourceKey {
}
struct Data {
}
class FileManager : NSObject {
struct DirectoryEnumerationOptions : OptionSet{
let rawValue: Int
}
func contentsOfDirectory(at url: URL, includingPropertiesForKeys keys: [URLResourceKey]?, options mask: FileManager.DirectoryEnumerationOptions = []) throws -> [URL] { return [] }
func contentsOfDirectory(atPath path: String) throws -> [String] { return [] }
func directoryContents(atPath path: String) -> [Any]? { return [] } // returns array of NSString
func subpathsOfDirectory(atPath path: String) throws -> [String] { return [] }
func subpaths(atPath path: String) -> [String]? { return [] }
func destinationOfSymbolicLink(atPath path: String) throws -> String { return "" }
func pathContentOfSymbolicLink(atPath path: String) -> String? { return "" }
func contents(atPath path: String) -> Data? { return nil }
}
// --- tests ---
func testFileHandle(fm: FileManager, url: URL, path: String) {
do
{
let contents1 = try fm.contentsOfDirectory(at: url, includingPropertiesForKeys: nil) // SOURCE
let contents2 = try fm.contentsOfDirectory(atPath: path) // SOURCE
let contents3 = fm.directoryContents(atPath: path)! // SOURCE
let subpaths1 = try fm.subpathsOfDirectory(atPath: path) // SOURCE
let subpaths2 = fm.subpaths(atPath: path)! // SOURCE
let link1 = try fm.destinationOfSymbolicLink(atPath: path) // SOURCE
let link2 = fm.pathContentOfSymbolicLink(atPath: path)! // SOURCE
let data = fm.contents(atPath: path)! // SOURCE
} catch {
// ...
}
}