hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #21038 from github/path-combine-name-desc-update

Browse Source 
Clarify Path.Combine call behavior
This commit is contained in:
Tom Hvitved
2025-12-18 12:54:38 +01:00
committed by GitHub
parent da99bbf6a6 a3c0082ac7
commit 47d0863bc5
3 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
csharp/ql/src/Bad Practices/PathCombine.ql
View File

@@ -1,6 +1,7 @@
/**
* @name Call to System.IO.Path.Combine
* @description Finds calls to System.IO.Path's Combine method
* @name Call to 'System.IO.Path.Combine' may silently drop its earlier arguments
* @description 'Path.Combine' may silently drop its earlier arguments
* if its later arguments are absolute paths.
* @kind problem
* @problem.severity recommendation
* @precision very-high
@@ -15,4 +16,4 @@ import semmle.code.csharp.frameworks.System
from MethodCall call
where call.getTarget().hasFullyQualifiedName("System.IO", "Path", "Combine")
select call, "Call to 'System.IO.Path.Combine'."
select call, "Call to 'System.IO.Path.Combine' may silently drop its earlier arguments."

4
csharp/ql/src/change-notes/2025-12-16-path-combine-metadata.md Normal file
View File

@@ -0,0 +1,4 @@
---
category: queryMetadata
---
* Updated the `name`, `description`, and alert message of `cs/path-combine` to have more details about why it's a problem.

2
csharp/ql/test/query-tests/Bad Practices/Path Combine/PathCombine.expected
View File

@@ -1 +1 @@
| PathCombine.cs:7:9:7:54 | call to method Combine | Call to 'System.IO.Path.Combine'. |
| PathCombine.cs:7:9:7:54 | call to method Combine | Call to 'System.IO.Path.Combine' may silently drop its earlier arguments. |