Fix expression always true query

2026-04-30 11:15:13 +02:00 · 2024-04-20 22:57:22 +02:00
parent 1a44d83ddb
commit 46d2bb24e5
3 changed files with 3 additions and 2 deletions
--- a/ql/lib/qlpack.yml
+++ b/ql/lib/qlpack.yml
@@ -2,7 +2,7 @@
 library: true
 warnOnImplicitThis: true
 name: githubsecuritylab/actions-all
-version: 0.0.12
+version: 0.0.13
 dependencies:
  codeql/util: ^0.2.0
  codeql/yaml: ^0.1.2
--- a/ql/src/Security/CWE-571/ExpressionIsAlwaysTrue.ql
+++ b/ql/src/Security/CWE-571/ExpressionIsAlwaysTrue.ql
@@ -15,6 +15,7 @@ import actions

 from If i
 where
+  i.getCondition().matches("%${{%") and
  i.getConditionStyle() = ["|", ">"]
  or
  i.getCondition().matches("%${{%") and
--- a/ql/src/qlpack.yml
+++ b/ql/src/qlpack.yml
@@ -1,7 +1,7 @@
 ---
 library: false
 name: githubsecuritylab/actions-queries
-version: 0.0.12
+version: 0.0.13
 groups:
  - actions
  - queries