hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-28 04:43:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Note value-preserving functions can't be constructors

Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
This commit is contained in:
Chris Smowton
2021-03-05 12:52:38 +00:00
committed by GitHub
parent 990bdc20b0
commit 45f3365d06
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/src/semmle/code/java/dataflow/FlowSteps.qll
View File

@@ -21,7 +21,7 @@ private module Frameworks {
}
/**
* A method or constructor that returns the exact value of one of its parameters or the qualifier.
* A method that returns the exact value of one of its parameters or the qualifier.
*
* Extend this class and override `returnsValue` to add additional value-preserving steps through a
* method that should be added to the basic local flow step relation.
@@ -29,16 +29,16 @@ private module Frameworks {
* These steps will be visible for all global data-flow purposes, as well as via
* `DataFlow::Node.getASuccessor` and other related functions exposing intraprocedural dataflow.
*/
abstract class ValuePreservingCallable extends Callable {
abstract class ValuePreservingMethod extends Method {
/**
* Holds if this callable returns precisely the value passed into argument `arg`.
* Holds if this method returns precisely the value passed into argument `arg`.
* `arg` is a parameter index, or is -1 to indicate the qualifier.
*/
abstract predicate returnsValue(int arg);
}
/**
* A method or constructor that returns the exact value of its qualifier (e.g., `return this;`)
* A method that returns the exact value of its qualifier (e.g., `return this;`)
*
* Extend this class and override `returnsValue` to add additional value-preserving steps through a
* method that should be added to the basic local flow step relation.